Skip to content

[BEAM-7823] Implementing a Custom NonCumulativeCost Handler#9159

Merged
akedin merged 1 commit intomasterfrom
unknown repository
Jul 26, 2019
Merged

[BEAM-7823] Implementing a Custom NonCumulativeCost Handler#9159
akedin merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 25, 2019

This is a custom NonCumulativeCost Handler just before transforming the logical plan to the physical plan. This way we can do things like cleaning the cache before computing the cost, implementing custom methods for cost estimation of Calcite's logical nodes without overriding them,...
This is done only for the PTransform path. Later it should also be done for JDBC path.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 25, 2019

R: @akedin

Copy link
Copy Markdown
Contributor

@akedin akedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akedin
Copy link
Copy Markdown
Contributor

akedin commented Jul 25, 2019

Run JavaPortabilityApi PreCommit

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 25, 2019

I forgot to rebase before pushing, I will push again.

@akedin
Copy link
Copy Markdown
Contributor

akedin commented Jul 25, 2019

Run Java PreCommit

@akedin akedin merged commit 1c639d1 into apache:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant