Skip to content

[BEAM-7797] Move upload_graph handling logic before template generation.#9128

Merged
aaltay merged 3 commits intoapache:masterfrom
azurezyq:template1
Jul 24, 2019
Merged

[BEAM-7797] Move upload_graph handling logic before template generation.#9128
aaltay merged 3 commits intoapache:masterfrom
azurezyq:template1

Conversation

@azurezyq
Copy link
Copy Markdown
Contributor

@azurezyq azurezyq commented Jul 23, 2019

Move upload_graph handling logic before template generation
R: @aaltay

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Jul 23, 2019

Could you fix the test errors?

@azurezyq
Copy link
Copy Markdown
Contributor Author

azurezyq commented Jul 24, 2019

Test errors are fixed. However "Run Spotless PreCommit" is failing with no logs:
https://builds.apache.org/job/beam_PreCommit_Spotless_Commit/4528/

Any idea what happened then?

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Jul 24, 2019

I see this error:

(see: https://builds.apache.org/job/beam_PreCommit_Spotless_Commit/4528/console)

13:46:31 * What went wrong:
13:46:31 Execution failed for task ':runners:google-cloud-dataflow-java:spotlessJava'.
13:46:31 > The following files had format violations:
13:46:31 runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
13:46:31 @@ -1309,8 +1309,8 @@
13:46:31
13:46:31 ··/**
13:46:31 ····Tests·that·the·{@link·DataflowRunner}·with·{@code·--templateLocation}·returns·normally·when·the
13:46:31 -····runner·is·successfully·run·with·upload_graph·experiment·turned·on.
13:46:31 -····The·result·template·should·not·contain·raw·steps·and·stepsLocation·file·should·be·set.
13:46:31 +····runner·is·successfully·run·with·upload_graph·experiment·turned·on.·The·result·template·should
13:46:31 +····not·contain·raw·steps·and·stepsLocation·file·should·be·set.
13:46:31 ···/
13:46:31 ··@test
13:46:31 ··public·void·testTemplateRunnerWithUploadGraph()·throws·Exception·{
13:46:31 Run 'gradlew spotlessApply' to fix these violations.

@aaltay aaltay merged commit 667bf85 into apache:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaltay aaltay aaltay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@azurezyq @aaltay