Skip to content

Remove redundant array creation code in InferableFunction and SimpleFunction#8192

Merged
aaltay merged 2 commits intoapache:masterfrom
robinyqiu:master
Apr 9, 2019
Merged

Remove redundant array creation code in InferableFunction and SimpleFunction#8192
aaltay merged 2 commits intoapache:masterfrom
robinyqiu:master

Conversation

@robinyqiu
Copy link
Copy Markdown
Contributor

when calling function that accepts varargs

r: @kennknowles

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@robinyqiu robinyqiu changed the title Remove redundant array creation code in InferableFunction Remove redundant array creation code in InferableFunction and SimpleFunction Apr 1, 2019
@kennknowles kennknowles self-requested a review April 1, 2019 23:02
@robinyqiu
Copy link
Copy Markdown
Contributor Author

Run Java PreCommit

Copy link
Copy Markdown
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we have a very long Java precommit queue. I will merge when green.

@adude3141
Copy link
Copy Markdown
Contributor

Run Java PreCommit

4 similar comments
@robinyqiu
Copy link
Copy Markdown
Contributor Author

Run Java PreCommit

@robinyqiu
Copy link
Copy Markdown
Contributor Author

Run Java PreCommit

@robinyqiu
Copy link
Copy Markdown
Contributor Author

Run Java PreCommit

@robinyqiu
Copy link
Copy Markdown
Contributor Author

Run Java PreCommit

@robinyqiu
Copy link
Copy Markdown
Contributor Author

Ping. PreCommit finally passed!

@robinyqiu
Copy link
Copy Markdown
Contributor Author

cc: @aaltay

@aaltay aaltay merged commit a490868 into apache:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants