Skip to content

[BEAM-3007] Add test which covers PCollection consumed by Flatten and another primitive.#3931

Closed
lukecwik wants to merge 1 commit intoapache:masterfrom
lukecwik:beam3007
Closed

[BEAM-3007] Add test which covers PCollection consumed by Flatten and another primitive.#3931
lukecwik wants to merge 1 commit intoapache:masterfrom
lukecwik:beam3007

Conversation

@lukecwik
Copy link
Copy Markdown
Member

@lukecwik lukecwik commented Oct 2, 2017 •
edited
Loading

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Oct 2, 2017

Run Dataflow ValidatesRunner

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Oct 3, 2017

https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/4087/ succeeded

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Oct 3, 2017

retest this please

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Oct 3, 2017 •
edited
Loading

R: @jkff @kennknowles

@kennknowles
Copy link
Copy Markdown
Member

kennknowles commented Oct 3, 2017

LGTM

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Oct 3, 2017

Python module crashed and is unrelated, majority of modules passed. Merging.

@asfgit asfgit closed this in 8d8f7fa Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukecwik @kennknowles