Skip to content

[BEAM-3004] Disable testReadPdfFile#3923

Closed
jasonkuster wants to merge 2 commits intoapache:masterfrom
jasonkuster:disable-test
Closed

[BEAM-3004] Disable testReadPdfFile#3923
jasonkuster wants to merge 2 commits intoapache:masterfrom
jasonkuster:disable-test

Conversation

@jasonkuster
Copy link
Copy Markdown
Contributor

Signed-off-by: Jason Kuster jasonkuster@google.com

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @kennknowles
CC: @sberyozkin
testReadPdfFile has been failing intermittently in PRs with nothing to do with TikaIO. Disabling until it can be deflaked.

https://builds.apache.org/view/A-D/view/Beam/job/beam_PreCommit_Java_MavenInstall/14691/org.apache.beam$beam-sdks-java-io-tika/testReport/org.apache.beam.sdk.io.tika/TikaIOTest/testReadPdfFile/history/

Signed-off-by: Jason Kuster <jasonkuster@google.com>
@jasonkuster
Copy link
Copy Markdown
Contributor Author

Run PreCommit Pipeline Java

Signed-off-by: Jason Kuster <jasonkuster@google.com>
@jasonkuster
Copy link
Copy Markdown
Contributor Author

Run PreCommit Pipeline Java

@kennknowles
Copy link
Copy Markdown
Member

LGTM. Given that the test is flaky and ignoring it is hardly likely to break the builds, I'll merge. Happy to see the pipeline going.

@jasonkuster
Copy link
Copy Markdown
Contributor Author

Run PreCommit Pipeline Java

1 similar comment
@jasonkuster
Copy link
Copy Markdown
Contributor Author

Run PreCommit Pipeline Java

@Rule
public TestPipeline p = TestPipeline.create();

@Ignore
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link back to the tracking issue.

@asfgit asfgit closed this in 9379ca2 Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants