[BEAM-2724] Updating BEAM_CONTAINER_VERSION for new worker#3912
[BEAM-2724] Updating BEAM_CONTAINER_VERSION for new worker#3912pabloem wants to merge 1 commit intoapache:masterfrom
Conversation
|
Run Python PostCommit |
|
jenkins: retest this please |
|
Changes Unknown when pulling 66a988a on pabloem:newworka into ** on apache:master**. |
|
Run Python PostCommit |
|
@charlesccychen tests have passed : ) |
| @@ -78,7 +78,7 @@ | |||
| # Update this version to the next version whenever there is a change that will | |||
| # require changes to legacy Dataflow worker execution environment. | |||
| # This should be in the beam-[version]-[date] format, date is optional. | |||
There was a problem hiding this comment.
The point of using a dated version string is that incompatibilities should not break users who check out the beam repo. We should rebuild a new container at the current date instead of using the catch-all dev container.
There was a problem hiding this comment.
I've updated to a dated container.
|
Run Python PostCommit |
|
@charlesccychen Done : ) |
charlesccychen
left a comment
There was a problem hiding this comment.
Thanks! This LGTM.
R: @chamikaramj for merge.
| @@ -78,7 +78,7 @@ | |||
| # Update this version to the next version whenever there is a change that will | |||
| # require changes to legacy Dataflow worker execution environment. | |||
| # This should be in the beam-[version]-[date] format, date is optional. | |||
There was a problem hiding this comment.
charlesccychen wrote:
The point of using a dated version string is that incompatibilities should not break users who check out the beam repo. We should rebuild a new container at the current date instead of using the catch-all dev container.
Done.
r: @charlesccychen
Updating to a new worker harness that supports structured names for msec counters.