Revert "Add gRPC experiments to Python dockerfile"#36572
Conversation
This reverts commit d687f4f.
Summary of ChangesHello @tvalentyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous change that introduced gRPC-related environment variables into the Python Dockerfile. The primary purpose of this revert is to avoid unintended side effects on gRPC functionality across all Python container environments, as the original modification was a broad attempt to address a specific flakiness issue observed only in Python 3.13. By reverting, the project aims to maintain stability and ensure gRPC functionality isn't inadvertently affected, while planning a more focused investigation into the Python 3.13 flakiness with the gRPC team. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
let's also open a cherry pick |
Reverts #36525.
#36525 might affect GRPC functionality in scenarios when a process launches subprocesses. We made this change an attempt to mitigate flakiness observed in Python 3.13 test suite.
Out of caution, let's revert, since #36525 would apply to all Python containers, not just 3.13.
Let's report test flakiness we observed in Python 3.13 to GRPC team in a separate issue. If we need to set any experiment like this, we may need to be mindful of minimal
grpcioversion on which such experiments are stable, let's first confirm them first with the GRPC team.