Conversation
|
beam_PostCommit_Java_Examples_Dataflow_Java: https://github.com/apache/beam/actions/runs/18286174083/job/52061661440 beam_PostCommit_Java_Examples_Dataflow_ARM: https://github.com/apache/beam/actions/runs/18290156063 beam_PostCommit_Java_Examples_Dataflow_V2_Java: https://github.com/apache/beam/actions/runs/18290257189 beam_PostCommit_Java_ValidatesRunner_Dataflow_JavaVersions: https://github.com/apache/beam/actions/runs/18297391474/job/52098424890 beam_PostCommit_Java_ValidatesRunner_Direct_JavaVersions: https://github.com/apache/beam/actions/runs/18286182845 |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers: R: @m-trieu for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
PreCommit Java PVR Prism Loopback failed 3 times: testComposedCombineWithContext checked that the same test also failing in other unrelated PRs (e.g. https://github.com/apache/beam/actions/runs/18231655679/job/51916196342). Also checked the same test passed locally when running the test alone, appears to be a flaky test |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damccorm
left a comment
There was a problem hiding this comment.
Thanks! LGTM, just had one question (doesn't need to be handled here, but should be an easy cleanup). Feel free to merge without addressing or after addressing
Fix #35627
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.