Fix Null Pointer Exception in BigQueryIO#36209
Merged
ahmedabu98 merged 1 commit intoapache:masterfrom Sep 22, 2025
Merged
Conversation
Contributor
|
Assigning reviewers: R: @m-trieu for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Contributor
|
valueProvider.get() check at pipeline submission time may not work: GoogleCloudPlatform/DataflowTemplates#2892 (comment) |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33074
Part-1: Check customGcsTempLocation value provider wrapping a null location. This is happening in Managed FileLoads path. While the next solution is to fix from client. This is part-1 fixes the BigQueryIO to be more robust in checking the null wrapped ValueProvider. We can add a stricter check that validates the value of customGcsTempLocation before hand. But we need to evaluate more paths and fix the client first.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.