Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue with the pre-commit Python transforms job by making adjustments to two test files. The changes ensure that pipeline tests are executed reliably by providing explicit runner configurations and preventing unintended optimization of PCollections.
Highlights
- External Transform Test Fix: Modified the 'test_external_transform_finder_leaf' to explicitly set 'DirectRunner' as a pipeline option, ensuring consistent test execution.
- Utility Test Pruning Prevention: Introduced a terminal consumer ('Count.PerElement()') in 'test_identity_window_fn_with_none_window' to prevent PCollection pruning, ensuring the test logic is fully executed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
|
||
| def test_external_transform_finder_leaf(self): | ||
| pipeline = beam.Pipeline() | ||
| opts = PipelineOptions(['--runner=DirectRunner']) |
There was a problem hiding this comment.
What problem is this causing? This should be the default, so I'm surprised this helps
There was a problem hiding this comment.
Check is failing so it doesn't help, I will continue to work on this
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
c0588c2 to
f94d1a8
Compare
a6c13e5 to
f68e589
Compare
| found = has_external(pipeline) | ||
| self.assertTrue(found, f"No ExternalTransform found; saw: {found}") |
There was a problem hiding this comment.
I think this removes the purpose of what we're testing here - we are trying to make sure that Beam can correctly identify external transforms when we run it.
There was a problem hiding this comment.
I think the core problem is that this is running on Prism, but Prism theoretically should be excluding this -
I'm not sure why it isn't yet, but taking a look
There was a problem hiding this comment.
Letting tests run now, but I validated #36049 should work locally and I think it is a better fix.
There was a problem hiding this comment.
Ok, let's try.
Also the issue usually relates only to this particular 'no-output' transform
Fixes #35832
Successful run: https://github.com/apache/beam/actions/runs/17402483884
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.