[Release-2.67] Cherry pick #35743 into release branch#35799
[Release-2.67] Cherry pick #35743 into release branch#35799damccorm merged 1 commit intoapache:release-2.67from
Conversation
* Fix BeamSQL CalcRel DATETIME expression * Add nullable array test case * fix checkstyle
There was a problem hiding this comment.
Summary of Changes
Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request cherry-picks a fix for BeamSQL's CalcRel DATETIME expression handling and introduces a new test case for nullable arrays. My primary goal is to ensure correct processing of various Joda-Time instant types within SQL queries and to improve test coverage for complex data types.
Highlights
- BeamSQL DATETIME Expression Fix: I've updated the BeamCalcRel to correctly handle DATETIME expressions by casting values to AbstractInstant instead of DateTime. This change ensures compatibility with both Instant and DateTime objects from Joda-Time when retrieving milliseconds.
- New Nullable Array Test Case: I've added a new test method, testNestedDatetime, in BeamComplexTypeTest to validate the behavior of nested arrays containing DATETIME values, specifically including cases with null elements. This enhances the robustness of BeamSQL's type handling.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Fix BeamSQL CalcRel DATETIME expression
Add nullable array test case
fix checkstyle
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.