Skip to content

Remove tox dependency#35679

Merged
Amar3tto merged 1 commit intomasterfrom
users/damccorm/tox
Jul 25, 2025
Merged

Remove tox dependency#35679
Amar3tto merged 1 commit intomasterfrom
users/damccorm/tox

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

@damccorm damccorm commented Jul 24, 2025

This currently requires tox to be installed at runtime in all settings since this is not part of our container. Really we just shouldn't be requiring this at all since this is only a problem in test environments.

Marking as release blocking since it is a perf regression (and an EOU problem)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm added this to the 2.67.0 Release milestone Jul 24, 2025
@damccorm damccorm mentioned this pull request Jul 24, 2025
Closed
3 tasks
@Amar3tto
Copy link
Copy Markdown
Collaborator

Amar3tto commented Jul 25, 2025 •
edited
Loading

In this case, do we need to move from cachetools 5.5.2 to 6.1 everywhere?
But the check is green, so I don't think it's necessary.

@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Jul 25, 2025

In this case, do we need to move from cachetools 5.5.2 to 6.1 everywhere? But the check is green, so I don't think it's necessary.

Yeah, I think it is fine. I checked and there shouldn't be any associated breaking changes which impact us, and this should auto-upgrade for our tests (but the container images will still use 5.5.2 which is probably good for this release).

@damccorm damccorm marked this pull request as ready for review July 25, 2025 11:55
@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Jul 25, 2025

R: @Amar3tto

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 25, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm damccorm mentioned this pull request Jul 25, 2025
Merged
3 tasks
@Amar3tto Amar3tto self-requested a review July 25, 2025 15:10
@Amar3tto Amar3tto merged commit e30edfc into master Jul 25, 2025
98 of 101 checks passed
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jul 25, 2025

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@damccorm damccorm deleted the users/damccorm/tox branch October 16, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amar3tto Amar3tto Amar3tto approved these changes

Assignees

No one assigned

Labels

python

Projects

None yet

Milestone

2.67.0 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@damccorm @Amar3tto