[Beam SQL] Support DATABASE concept in Beam SQL, with implementation for Iceberg#35641
Merged
ahmedabu98 merged 5 commits intoapache:masterfrom Jul 22, 2025
Merged
[Beam SQL] Support DATABASE concept in Beam SQL, with implementation for Iceberg#35641ahmedabu98 merged 5 commits intoapache:masterfrom
ahmedabu98 merged 5 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @talatuyarer |
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
17 tasks
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
...ions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/parser/SqlCreateDatabase.java
Outdated
Show resolved
Hide resolved
tarun-google
approved these changes
Jul 22, 2025
Contributor
tarun-google
left a comment
There was a problem hiding this comment.
LGTM !! Great work fixing gap in Iceberg Beam SQL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35641 +/- ##
=========================================
Coverage 56.54% 56.54%
Complexity 3382 3382
=========================================
Files 1205 1205
Lines 183856 183856
Branches 3477 3477
=========================================
Hits 103961 103961
Misses 76577 76577
Partials 3318 3318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #35637
These changes allow the following:
CREATE DATABASE ( IF NOT EXISTS )? database_nameUSE DATABASE database_nameDROP DATABASE [ IF EXISTS ] database_name [ RESTRICT | CASCADE ]RESTRICT(default) will throw an error if the database contains a table.CASCADEwill drop all tables within the database before dropping the database.For Iceberg catalogs,
CREATEandDROPwill create/drop real external tables in the appropriate data platform.These implementations will help bring Beam closer to alignment with existing Flink and Spark syntax