Skip to content

add input data file for example tests#35054

Merged
shunping merged 5 commits intoapache:masterfrom
derrickaw:phase0_yamlAddInputDataFile
May 30, 2025
Merged

add input data file for example tests#35054
shunping merged 5 commits intoapache:masterfrom
derrickaw:phase0_yamlAddInputDataFile

Conversation

@derrickaw
Copy link
Copy Markdown
Collaborator

@derrickaw derrickaw commented May 27, 2025 •
edited
Loading

#35030 Phase 1

Move out the input data from the test file to a separate file.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@derrickaw derrickaw marked this pull request as ready for review May 28, 2025 13:45
@derrickaw derrickaw mentioned this pull request May 28, 2025
Open
22 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@derrickaw
Copy link
Copy Markdown
Collaborator Author

derrickaw commented May 28, 2025

assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2025

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@derrickaw
Copy link
Copy Markdown
Collaborator Author

derrickaw commented May 28, 2025

Run PythonDocs Precommit

@derrickaw derrickaw force-pushed the phase0_yamlAddInputDataFile branch from f019f3b to 52a1101 Compare May 30, 2025 15:47
@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.45%. Comparing base (bbf7124) to head (52a1101).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #35054      +/-   ##
============================================
- Coverage     56.48%   56.45%   -0.04%     
  Complexity     3299     3299              
============================================
  Files          1185     1186       +1     
  Lines        181794   181951     +157     
  Branches       3409     3409              
============================================
+ Hits         102691   102715      +24     
- Misses        75837    75970     +133     
  Partials       3266     3266
Flag Coverage Δ
python 80.91% <100.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shunping
shunping approved these changes May 30, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shunping shunping left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The failed tests are unrelated to the changes.

@shunping shunping merged commit ac501c6 into apache:master May 30, 2025
91 of 94 checks passed
@derrickaw derrickaw deleted the phase0_yamlAddInputDataFile branch May 30, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shunping shunping shunping approved these changes

Assignees

No one assigned

Labels

Next Action: Reviewers python yaml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@derrickaw @shunping