Skip to content

Rethrowing Exception from CassandraIO's ReadFn#34191

Merged
kennknowles merged 1 commit intoapache:masterfrom
VardhanThigle:cassandra-io
May 21, 2025
Merged

Rethrowing Exception from CassandraIO's ReadFn#34191
kennknowles merged 1 commit intoapache:masterfrom
VardhanThigle:cassandra-io

Conversation

@VardhanThigle
Copy link
Copy Markdown
Contributor

@VardhanThigle VardhanThigle commented Mar 6, 2025 •
edited
Loading

Please add a meaningful description for your change here

Rethrowing Exception from CassandraIO's ReadFn

Addresses #34160

Note to reviewers

There are 2 high level approaches discussed in #34160:

  1. Rethrow
  2. Let the user plug in an exception handler.
    While a default Rethrow might change the behavior from silently logging errors and proceeding, not doing so has issues of data correctness as rows that get any errors are never read and the pipeline still succeeds.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@VardhanThigle
Copy link
Copy Markdown
Contributor Author

VardhanThigle commented Mar 7, 2025

assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2025

Reminder, please take a look at this pr: @robertwb @damondouglas

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2025

Reminder, please take a look at this pr: @kennknowles @ahmedabu98

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2025

Reminder, please take a look at this pr: @damondouglas @johnjcasey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 21, 2025

Reminder, please take a look at this pr: @ahmedabu98 @johnjcasey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 2, 2025

Reminder, please take a look at this pr: @chamikaramj @johnjcasey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 6, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@derrickaw
Copy link
Copy Markdown
Collaborator

derrickaw commented May 12, 2025

Hi @kennknowles and @johnjcasey - please review when you get a chance. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 20, 2025

Reminder, please take a look at this pr: @kennknowles @johnjcasey

@VardhanThigle VardhanThigle mentioned this pull request Jun 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennknowles kennknowles kennknowles approved these changes

Assignees

No one assigned

Labels

cassandra io java Next Action: Reviewers slow-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VardhanThigle @derrickaw @kennknowles