Place bounded lineage metrics under a new name.#33482
Conversation
This avoids any potential complexities with mixing old and new metrics with the same name but different types (e.g. after a streaming update across an sdk upgrade).
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
@robertwb is this ready to be merged? |
Yes. Thanks for the ping. |
| LINEAGE_NAMESPACE = "lineage" | ||
| SOURCE = "sources" | ||
| SINK = "sinks" | ||
| SOURCE = "sources_v2" |
There was a problem hiding this comment.
Since metrics are namespaced would it be better to do keep name sources and sinks itself and change the namespace to lineage_v2?
There was a problem hiding this comment.
The division between the namespace and non-namespace portion of a name are somewhat arbitrary... Keeping the namespace the same is nice because it allows one to query for all lineage counters (even as they evolve) but I don't feel too strongly about this.
There was a problem hiding this comment.
SG. I agree either way is fine. Lets keep the namespace common then. Thanks.
This avoids any potential complexities with mixing old and new metrics with the same name but different types (e.g. after a streaming update across an sdk upgrade).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.