Remove remaining Python 3.8 Artifacts#32913
Merged
jrmccluskey merged 3 commits intomasterfrom Oct 29, 2024
Merged
Conversation
Contributor
Author
|
The changes to the Python 3.9 post-commit are the most substantial, running at https://github.com/apache/beam/actions/runs/11485756985/job/31966569465 |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
tvalentyn
approved these changes
Oct 23, 2024
Contributor
Author
|
PostCommit failures on the branch are due to #32936 |
3 tasks
damccorm
reviewed
Oct 31, 2024
| // The default container uses Python 3.10. The goal here is to | ||
| // duild Docker images for TensorRT tests during run time for python versions | ||
| // other than 3.10 and add these tests in other python postcommit suites. | ||
| dependsOn(":sdks:python:test-suites:dataflow:py310:inferencePostCommitIT") |
Contributor
There was a problem hiding this comment.
Looks like this change broke the TensorRT tests - https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python.yml
The reason is that TensorRT depends on a docker image -
- which is static, not built based on the test suite its in (this is actually what the comment in this file is saying).I think we need to use
us.gcr.io/apache-beam-testing/python-postcommit-it/tensor_rt:latest. @jrmccluskey would you mind following up and doing that? It looks like you already updated the dockerfile, so hopefully its smooth sailing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes remaining artifacts around Python 3.8 support, calls out support deprecation in CHANGES.md
Closes #31192
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.