[KafkaIO] Determine partition backlog using endOffsets instead of seek2End and position#32889
Merged
johnjcasey merged 4 commits intoapache:masterfrom Nov 6, 2024
Merged
Conversation
f6f67bb to
0edb636
Compare
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
8ae8b79 to
fd8820a
Compare
84e07a7 to
5593321
Compare
5593321 to
e9bddc9
Compare
Contributor
|
Hi, have you been able to get a KafkaIO reviewer? Reviewbot possibly needs a Kafka label. |
Merged
3 tasks
johnjcasey
requested changes
Oct 30, 2024
Contributor
johnjcasey
left a comment
There was a problem hiding this comment.
Can you run this version and see if we see the sawtooth backlog pattern, or if this resolves that issue?
...sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/KafkaTestTable.java
Outdated
Show resolved
Hide resolved
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java
Show resolved
Hide resolved
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
endOffsetsinstead ofseekToEndandpositionto determine the backlog element size inKafkaUnboundedReaderandReadFromKafkaDoFn. Determining the end offsets by seeking and retrieving the position may triggerpolland prefetch records which will never be consumed by the offset consumer.Forcibly retrieving the partition's high watermark in offset consumers might not be necessary, but this will be addressed separately.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.