[prism] Dev prism builds for python and Python Direct Runner fallbacks. #32876
Merged
lostluck merged 11 commits intoapache:masterfrom Oct 21, 2024
Merged
[prism] Dev prism builds for python and Python Direct Runner fallbacks. #32876lostluck merged 11 commits intoapache:masterfrom
lostluck merged 11 commits intoapache:masterfrom
Conversation
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
approved these changes
Oct 21, 2024
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Thanks! This LGTM once checks pass (https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-LintandFormattingChecks may help)
Contributor
Author
|
I discovered the root of my problem was using a newer yapf than Beam does, (0.40, instead of 0.29), so now I can have the formatting enabled on save, which will help! Local Linting on the other hand eludes me. I'm fortunately not tickling that as often. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does two tasks:
The main change is to the prism_runner behavior when the SDK reports a
.devversion.In that case:
go install github.com/apache/beam/sdks/v2/go/cmd/prismto the binary cache directory.Arguably independently, is Attempt To Use Prism in the direct runner.
Other changes are a refactor to reverse a few if blocks and return earlier, improving readability and reducing indentations.
Part of #32564
Fixes #32877.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.