Move GitHub Actions workflows to Flink 1.19 and remove 1.15 and 1.16#32837
Move GitHub Actions workflows to Flink 1.19 and remove 1.15 and 1.16#32837kennknowles merged 2 commits intoapache:masterfrom
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Thanks. This is a good start. Took a look there are multiple reference to flink 1.15 in current GHA:
|
fc6401c to
a664821
Compare
|
I got the rest of them, I think. |
|
I haven't used GHA configs deeply in a long time but maybe we can put this in a variable somewhere. |
Ah, it looks like this may require talking to infra every time we change, so that isn't worth it. https://docs.github.com/en/enterprise-cloud@latest/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#defining-configuration-variables-for-multiple-workflows |
There was a problem hiding this comment.
OK yea we should be able to set a "latest" or "live" flink version here, or create a new section that isn't Java-only since Flink is used in many non-Java situations.
There was a problem hiding this comment.
yes that could be a follow up
d96482d to
fb1a381
Compare
|
Thanks! |
These changes need to happen before #32836 because the tests will pull their definitions from
masterbranch.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.