Merged
Conversation
16 tasks
3 tasks
16 tasks
3 tasks
3 tasks
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
tvalentyn
commented
May 22, 2024
sdks/python/tox.ini
Outdated
Contributor
Author
There was a problem hiding this comment.
note: I removed 310/311 python versions from some configurations since we don't have any tests that exercise these configurations. We might be upgrading to Python 3.9 soon, so left that for now.
damccorm
reviewed
May 23, 2024
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Thanks! Just had minor comments
damccorm
approved these changes
May 23, 2024
Contributor
damccorm
left a comment
There was a problem hiding this comment.
LGTM (pending one open thread)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Python 3.12.0
fixes: #29149
Some Python PostCommit GHA test results from a branch created against Apache Repo :
future work:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.