Conversation
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
R: @damccorm |
| ] | ||
|
|
||
| def commonRunnerV2ExcludeCategories = [ | ||
| 'org.apache.beam.sdk.testing.UsesExternalService', |
There was a problem hiding this comment.
Will this result in all Runner V2 test suites not running x-lang tests (essentially disabling all x-lang tests) ?
There was a problem hiding this comment.
"commonRunnerV2ExcludeCategories" is only used in "createRunnerV2ValidatesRunnerTest" in runners/google-cloud-dataflow-java/build.gradle. For XVR test, it is created in createCrossLanguageValidatesRunnerTask that defined in BeamModulePlugin. So this won't get excluded.
There was a problem hiding this comment.
Ah, thanks. We should fix the name in that case.
|
LGTM (minus test failures) |
|
Failed tests:
|
|
Let me merge this to get the postcommits back work then investigating unrelated test failures |
fix #30353
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.