Update google-api-services-storage to match libraries-bom#29864
Merged
jrmccluskey merged 1 commit intoapache:masterfrom Dec 22, 2023
Merged
Update google-api-services-storage to match libraries-bom#29864jrmccluskey merged 1 commit intoapache:masterfrom
jrmccluskey merged 1 commit intoapache:masterfrom
Conversation
``` cd /tmp; wget https://repo1.maven.org/maven2/com/google/cloud/libraries-bom/26.28.0/libraries-bom-26.28.0.pom -O base.pom && mvn help:effective-pom -f base.pom -Doutput=effective.pom && cat effective.pom | grep -v 'dependencyManagement' > cleanup.pom && mvn dependency:tree -f cleanup.pom ``` Yields ``` [INFO] | +- com.google.apis:google-api-services-storage:jar:v1-rev20231202-2.0.0:compile ``` Making the change accordingly, since this mismatch is causing some errors on RC validation: https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1233/checks?check_run_id=19897484522 ``` java.lang.NoClassDefFoundError: com/google/api/services/storage/model/Bucket$ObjectRetention at com.google.cloud.storage.JsonConversions.<init>(JsonConversions.java:120) at com.google.cloud.storage.JsonConversions.<clinit>(JsonConversions.java:89) at com.google.cloud.storage.Conversions.json(Conversions.java:33) at com.google.cloud.storage.StorageImpl.<clinit>(StorageImpl.java:109) ```
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
jrmccluskey
approved these changes
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yields
Making the change accordingly, since this mismatch is causing some errors on RC validation: https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1233/checks?check_run_id=19897484522
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.