Skip to content

Fix GenerateSequenceSchemaTransformProvider formatting#29798

Merged
Abacn merged 1 commit intomasterfrom
users/damccorm/spotBugs
Dec 18, 2023
Merged

Fix GenerateSequenceSchemaTransformProvider formatting#29798
Abacn merged 1 commit intomasterfrom
users/damccorm/spotBugs

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

@damccorm damccorm commented Dec 18, 2023

Right now, this is breaking the java precommit because it is causing a spotbugs failure.

Example: https://github.com/apache/beam/actions/runs/7245514035/job/19735677563

From the report:

FS | Format string should use %n rather than \n in org.apache.beam.sdk.providers.GenerateSequenceSchemaTransformProvider.description()

  | Bug type VA_FORMAT_STRING_USES_NEWLINE (click for details)In class org.apache.beam.sdk.providers.GenerateSequenceSchemaTransformProviderIn method org.apache.beam.sdk.providers.GenerateSequenceSchemaTransformProvider.description()Called method String.format(String, Object[])Format string "Outputs a PCollection of Beam Rows, each containing a single INT64 number called "value". The count is produced from the given "start"value and either up to the given "end" or until 2^63 - 1.\nTo produce an unbounded PCollection, simply do not specify an "end" value. Unbounded sequences can specify a "rate" for output elements.\nIn all cases, the sequence of numbers is generated in parallel, so there is no inherent ordering between the generated values"At GenerateSequenceSchemaTransformProvider.java:[line 67]

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Dec 18, 2023 •
edited
Loading

R: @Abacn @ahmedabu98 @chamikaramj

@github-actions github-actions bot added the java label Dec 18, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm damccorm mentioned this pull request Dec 18, 2023
Merged
3 tasks
This was referenced Dec 18, 2023
Merged
Merged
@Abacn Abacn merged commit add3438 into master Dec 18, 2023
@Abacn Abacn mentioned this pull request Dec 18, 2023
Closed
@damccorm damccorm deleted the users/damccorm/spotBugs branch December 18, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennknowles kennknowles kennknowles approved these changes

@Abacn Abacn Abacn approved these changes

Assignees

No one assigned

Labels

java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damccorm @kennknowles @Abacn