Fixes breakages of the upgrade feature (#29731)#29766
Merged
jrmccluskey merged 1 commit intoapache:release-2.53.0from Dec 15, 2023
Merged
Fixes breakages of the upgrade feature (#29731)#29766jrmccluskey merged 1 commit intoapache:release-2.53.0from
jrmccluskey merged 1 commit intoapache:release-2.53.0from
Conversation
* Fixes breakages of the upgrade feature * Fix spotless * Addressing reviewer comments * Removing unused import * Reverting the PreCommit update
Contributor
Author
|
R: @jrmccluskey |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
jrmccluskey
approved these changes
Dec 14, 2023
Contributor
jrmccluskey
left a comment
There was a problem hiding this comment.
LGTM waiting on tests
Contributor
|
Looks like the workflow picks up from the target branch so bumping the timeout on master won't impact here. I'm inclined to move forward and get the cherrypick in, if we have any more problems we can address them in another cherrypick/an RC2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #29731 to the 2.53.0 release branch.
This fixes #29730.
Fixes breakages of the upgrade feature
Fix spotless
Addressing reviewer comments
Removing unused import
Reverting the PreCommit update
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.