Skip to content

[YAML] Fix PyPi caching for non-dev beam#29273

Merged
damccorm merged 1 commit intoapache:masterfrom
Polber:jkinard/fix-cache
Nov 3, 2023
Merged

[YAML] Fix PyPi caching for non-dev beam#29273
damccorm merged 1 commit intoapache:masterfrom
Polber:jkinard/fix-cache

Conversation

@Polber
Copy link
Copy Markdown
Contributor

@Polber Polber commented Nov 2, 2023

Pyenv caching fails on non-dev versions of beam when running Beam YAML cache_provider_artifacts.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@Polber
Copy link
Copy Markdown
Contributor Author

Polber commented Nov 2, 2023

R: @robertwb

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 2, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 2, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm
Copy link
Copy Markdown
Contributor

damccorm commented Nov 3, 2023

Run Python_Coverage PreCommit

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 3, 2023

Codecov Report

Merging #29273 (067d995) into master (e03988e) will decrease coverage by 0.04%.
Report is 26 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #29273      +/-   ##
==========================================
- Coverage   38.31%   38.28%   -0.04%     
==========================================
  Files         688      689       +1     
  Lines      101879   101991     +112     
==========================================
+ Hits        39040    39043       +3     
- Misses      61259    61368     +109     
  Partials     1580     1580              
Flag Coverage Δ
python 29.88% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ython/apache_beam/yaml/cache_provider_artifacts.py 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@damccorm damccorm merged commit a3fe3fa into apache:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants