Fix whitespace precommit after gradle 8#28845
Conversation
|
It failed on gradle 8 because the zip src folder includes the python virtualenv folder, explicitly set here (was a workaround of gradle gc behavior): in general we should not include gradle intermediate dir **/build/**
It failed locally for different reason. Beam repo linked to google/docsy : https://github.com/apache/beam/tree/master/website/www/site/themes For some reason this file is present locally but not on GHA / Jenkins (previously) |
|
Run Whitespace PreCommit test passed: https://github.com/apache/beam/actions/runs/6419609343/job/17429832396 |
Codecov Report
@@ Coverage Diff @@
## master #28845 +/- ##
==========================================
- Coverage 72.22% 72.21% -0.01%
==========================================
Files 684 684
Lines 101230 101230
==========================================
- Hits 73110 73106 -4
- Misses 26545 26549 +4
Partials 1575 1575
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
python coverage passed on GHA |
Fixes #28756 (comment)
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.