Skip to content

Cherry picking PR #28618 into 2.51.0 (setting numShards for Python BigQuery xlang)#28631

Merged
kennknowles merged 8 commits intoapache:release-2.51.0from
ahmedabu98:cp_28618
Sep 27, 2023
Merged

Cherry picking PR #28618 into 2.51.0 (setting numShards for Python BigQuery xlang)#28631
kennknowles merged 8 commits intoapache:release-2.51.0from
ahmedabu98:cp_28618

Conversation

@ahmedabu98
Copy link
Copy Markdown
Contributor

@ahmedabu98 ahmedabu98 commented Sep 22, 2023

Cherry picking PR #28618 into 2.51.0

@ahmedabu98 ahmedabu98 marked this pull request as ready for review September 22, 2023 20:50
@ahmedabu98 ahmedabu98 added this to the 2.51.0 Release milestone Sep 22, 2023
@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Sep 22, 2023

R: @kennknowles

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 22, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Sep 23, 2023

Run Python_Xlang_Gcp_Dataflow PostCommit

@ahmedabu98 ahmedabu98 changed the base branch from master to release-2.51.0 September 23, 2023 00:33
@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Sep 23, 2023

Run Python_Xlang_Gcp_Direct PostCommit

@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Sep 23, 2023

Previous iteration of xlang direct GCP tests failed because it was running on another PR concurrently.. shows another occurrence of #27445

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Sep 23, 2023

fyi test passed on GitHub Action also: https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python_Xlang_Gcp_Direct.yml?query=event%3Aissue_comment

Though current phrase trigger on GitHub Action is not conveniently visible (we're investigating a solution)

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #28631 (490605b) into release-2.51.0 (6306b21) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@               Coverage Diff               @@
##           release-2.51.0   #28631   +/-   ##
===============================================
  Coverage           72.23%   72.23%           
===============================================
  Files                 684      684           
  Lines              101071   101073    +2     
===============================================
+ Hits                73004    73009    +5     
+ Misses              26491    26488    -3     
  Partials             1576     1576
Flag Coverage Δ
python 82.81% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery.py 69.92% <50.00%> (-0.05%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahmedabu98 ahmedabu98 changed the title Cherry picking PR #28618 into 2.51.0 Cherry picking PR #28618 into 2.51.0 (setting numShards for Python BigQuery xlang) Sep 23, 2023
@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Sep 24, 2023

Run Python_Xlang_Gcp_Dataflow PostCommit

@ahmedabu98 ahmedabu98 mentioned this pull request Sep 25, 2023
Closed
15 tasks
@kennknowles
Copy link
Copy Markdown
Member

kennknowles commented Sep 27, 2023

PreCommit Python Dataframes / Test Results (pull_request_target) only has the option to re-run all jobs. I don't know what causes that but I'm afraid of causing flakiness by rerunning too much. WDYT? Is that the way to go? Is there a real problem? It didn't dump me to the console I was expecting to see in order to triage it.

@kennknowles
Copy link
Copy Markdown
Member

kennknowles commented Sep 27, 2023

Ah, I see the failures are still Fhir. Why is it running in the dataframes precommit? Well anyhow I will merge this cherrypick also. However, those jobs should be disabled until they are healthy.

@kennknowles kennknowles merged commit 2420c90 into apache:release-2.51.0 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dataflow gcp infra io java python runners website

Projects

None yet

Milestone

2.51.0 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmedabu98 @Abacn @kennknowles