Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Run Java_GCP_IO_Direct PreCommit

Run Java PreCommit

Hello, @damondouglas. I really appreciate for your review and your suggestion.
I have a question about your suggestion.

As far as I understand, even though I found every occurrences of readFullyAsUTF8String(), I think that there is no relationship between readFullyAsUTF8String() method and reading TextSource or FileBasedSource. Could you explain where can I find connection between them?

Hello, @damondouglas. I really appreciate for your review and your suggestion. I have a question about your suggestion.

As far as I understand, even though I found every occurrences of readFullyAsUTF8String(), I think that there is no relationship between readFullyAsUTF8String() method and reading TextSource or FileBasedSource. Could you explain where can I find connection between them?

Hello @gudfhr95, It's nice to hear from you and thank you for your response. I just created this example gist that uses FileIO.ReadableFile's readFullyAsUTF8String method. In the gist, I performed the line skipping in a DoFn as copied from the gist below.

@ProcessElement
public void process(@Element ReadableFile element) {
        String rawData = element.readFullyAsUTF8String();
        Stream<String> lines = rawData.lines().skip(/* int */ skipLines);
        List<String> result = lines.collect(Collectors.toList());
}

https://gist.github.com/damondouglas/84c34469d4a6d7b7483468659482855c. Note you can copy the entire contents of the gist and replace the text of https://play.beam.apache.org/ and run on its own.

However, I can see this code in a new readFullyAsUTF8String method that takes an int skipLines argument. So the above DoFn could look like this:

@ProcessElement
public void process(@Element ReadableFile element) {
        List<String> lines = element.readFullyAsUTF8String(/* int */ skipLines);
}

Ah, I see. Thank you for your detailed examples.
Your suggestion is to add a utility methods in ReadableFIles.

Then, I think that I should revert my previous commits and create new PR only containing readFullyAsUTF8String(int skipLines)
I'll do it ASAP and request your review.

Again, thank you for your kind explanation @damondouglas!

@gudfhr95 Take your time. Again, we are very grateful for your contribution and thank you again for listening to my feedback. I look forward to talking with you soon.