Conversation
|
It fails on this PR due to inconsistent setup-action.yml run between setup (yml on master) and post setup (yml been overwritten). This is actually the same direct cause of #27854 a github action issue |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
| github.event_name == 'schedule' || | ||
| github.event_name == 'workflow_dispatch' | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} |
There was a problem hiding this comment.
Hm, for push/schedule/workflow_dispatch, we probably don't even need this checkout, do we?
There was a problem hiding this comment.
Using the pull_request event doesn't really make sense and we've already done the checkout previously to get access to this action
There was a problem hiding this comment.
yeah that's right. Changed and tested on https://github.com/Abacn/beam/actions/runs/5787197443/job/15683590845
|
Looks like this didn't work - https://github.com/apache/beam/actions/runs/5795001413/job/15705720400?pr=27893 |
|
Actually, that may just be because there were merge conflicts in the PR #27893 |
|
I see, when there is a merge conflict, the ref to then it falls back to the pull request branch head if there is merge conflicts, which is the current Jenkins behavior. |
Fixes #27854
example run:
it appears there is still an issue in the pull request trigger. Once triggered, it will abort the push or schedule run on master branch
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.