Skip to content

Fix failing python postcommits#27662

Merged
riteshghorse merged 1 commit intoapache:masterfrom
ahmedabu98:fix_python_test
Jul 25, 2023
Merged

Fix failing python postcommits#27662
riteshghorse merged 1 commit intoapache:masterfrom
ahmedabu98:fix_python_test

Conversation

@ahmedabu98
Copy link
Copy Markdown
Contributor

@ahmedabu98 ahmedabu98 commented Jul 25, 2023 •
edited
Loading

Fixes #27643

@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Jul 25, 2023

R: @riteshghorse
R: @BjornPrime

@ahmedabu98 ahmedabu98 mentioned this pull request Jul 25, 2023
Closed
15 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 25, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@ahmedabu98
Copy link
Copy Markdown
Contributor Author

ahmedabu98 commented Jul 25, 2023

Confirmed the fix by running the test bigquery_read_it_test.py::ReadUsingStorageApiTests::test_iobase_source_with_very_selective_filters locally before and after

@riteshghorse
Copy link
Copy Markdown
Contributor

riteshghorse commented Jul 25, 2023

Run Python 3.11 PostCommit

riteshghorse
riteshghorse approved these changes Jul 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #27662 (30383c0) into master (6cd6410) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #27662      +/-   ##
==========================================
- Coverage   70.93%   70.93%   -0.01%     
==========================================
  Files         861      861              
  Lines      104806   104807       +1     
==========================================
  Hits        74341    74341              
- Misses      28907    28908       +1     
  Partials     1558     1558
Flag Coverage Δ
python 80.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ython/apache_beam/io/gcp/bigquery_read_internal.py 57.89% <100.00%> (+0.20%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@riteshghorse
Copy link
Copy Markdown
Contributor

riteshghorse commented Jul 25, 2023

Bigquery tests are now passing in Py 3.11 PC.

Other failures are not related to this change. Merging this one!

@riteshghorse riteshghorse merged commit 1273d22 into apache:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riteshghorse riteshghorse riteshghorse approved these changes

Assignees

No one assigned

Labels

gcp io python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Failing Test]: Python PostCommits are red with failing bigquery test

2 participants

@ahmedabu98 @riteshghorse