Skip to content

Add PubsubWriteIT tests, with validations to bounded writes#27286

Merged
johnjcasey merged 1 commit intoapache:masterfrom
bvolpato:pubsubio-write-tests
Aug 8, 2023
Merged

Add PubsubWriteIT tests, with validations to bounded writes#27286
johnjcasey merged 1 commit intoapache:masterfrom
bvolpato:pubsubio-write-tests

Conversation

@bvolpato
Copy link
Copy Markdown
Contributor

Adding tests that would've caught regression observed in #27000.

@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@bvolpato
Copy link
Copy Markdown
Contributor Author

Run Kotlin_Examples PreCommit

@bvolpato bvolpato force-pushed the pubsubio-write-tests branch from 32f5612 to 32a2566 Compare July 27, 2023 02:40
@bvolpato
Copy link
Copy Markdown
Contributor Author

assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 3, 2023

Reminder, please take a look at this pr: @robertwb @chamikaramj

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 8, 2023

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@johnjcasey johnjcasey merged commit d0843a0 into apache:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants