Skip to content

Eliminate nullness errors from MongoDbIO#26481

Merged
kennknowles merged 1 commit intoapache:masterfrom
kennknowles:mongodb-nullness
May 1, 2023
Merged

Eliminate nullness errors from MongoDbIO#26481
kennknowles merged 1 commit intoapache:masterfrom
kennknowles:mongodb-nullness

Conversation

@kennknowles
Copy link
Copy Markdown
Member

I didn't try to change the design. There are probably ways to redesign the internals a bit to consolidate the checks and get better messages. But as it is they would just be NPEs in random places, so this allows us to turn on the type checking that will protect any refactor from problems.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Copy Markdown
Contributor

@johnjcasey johnjcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't know MongoDbIO to know if any of these annotations might be inaccurate, but all the annotations follow from what existed before.

@kennknowles
Copy link
Copy Markdown
Member Author

Yea I don't really know the IO other than the digging I did because I happened to be touching it. I believe I mostly just added annotations that were clearly necessary and checks that were also clearly necessary. And beyond that I trust the tests.

@kennknowles
Copy link
Copy Markdown
Member Author

My main goal is to remove the blanket suppressions so that people don't apply them to new code produced by copy/paste.

@kennknowles
Copy link
Copy Markdown
Member Author

I did also potentially add some "setting to null" that will allow things to be GC'd, but not in a way that will matter.

@kennknowles kennknowles merged commit e143a44 into apache:master May 1, 2023
@kennknowles kennknowles deleted the mongodb-nullness branch May 1, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants