Python 3.11 with a patch to current pickler.#26120
Closed
tvalentyn wants to merge 22 commits intoapache:masterfrom
Closed
Python 3.11 with a patch to current pickler.#26120tvalentyn wants to merge 22 commits intoapache:masterfrom
tvalentyn wants to merge 22 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Run Seed Job |
1 similar comment
Contributor
Author
|
Run Seed Job |
tvalentyn
commented
Apr 5, 2023
| # Leaving 'future' in our containers for now prevent breaking tft users. | ||
| future | ||
| guppy3 # Memory profiler | ||
| guppy3;python_version<"3.11" # Memory profiler |
Contributor
Author
|
Run Seed Job |
Contributor
Author
|
Run Seed Job |
AnandInguva
reviewed
Apr 5, 2023
| nltk # Commonly used for natural language processing. | ||
| nose==1.3.7 # For Dataflow internal testing. TODO: remove this. | ||
| python-snappy # Optimizes execution of some Beam codepaths. | ||
| python-snappy;python_version<"3.11" # Optimizes execution of some Beam codepaths. |
Contributor
There was a problem hiding this comment.
Suggested change
| python-snappy;python_version<"3.11" # Optimizes execution of some Beam codepaths. | |
| # TODO: Uncomment python version once python-snappy supports it. | |
| # https://github.com/apache/beam/issues/25985 | |
| python-snappy;python_version<"3.11" # Optimizes execution of some Beam codepaths. |
| # Leaving 'future' in our containers for now prevent breaking tft users. | ||
| future | ||
| guppy3 # Memory profiler | ||
| guppy3;python_version<"3.11" # Memory profiler |
Contributor
There was a problem hiding this comment.
Suggested change
| guppy3;python_version<"3.11" # Memory profiler | |
| # TODO: Uncomment python version once guppy supports it. | |
| # https://github.com/apache/beam/issues/25984 | |
| guppy3;python_version<"3.11" # Memory profiler |
Contributor
|
Run Python 3.11 PostCommit |
Contributor
Author
|
Run Python Dataflow V2 ValidatesRunner |
Contributor
|
Run Python 3.11 PostCommit |
Contributor
Author
|
Noting that tests have passed, but status have not propagated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.