Skip to content

Force version of sklearn in examples#25968

Merged
damccorm merged 9 commits intomasterfrom
users/damccorm/sklearn_tests
Mar 27, 2023
Merged

Force version of sklearn in examples#25968
damccorm merged 9 commits intomasterfrom
users/damccorm/sklearn_tests

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

@damccorm damccorm commented Mar 24, 2023 •
edited
Loading

Force sklearn version to the same version the models were trained on. This ensures that the examples will pass correctly.

Fixes #25967

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Mar 24, 2023

Run Python 3.9 PostCommit

@damccorm damccorm marked this pull request as draft March 24, 2023 18:51
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2023 •
edited
Loading

Codecov Report

Merging #25968 (27d611a) into master (3a1b641) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master   #25968      +/-   ##
==========================================
- Coverage   71.42%   71.41%   -0.01%     
==========================================
  Files         779      779              
  Lines      102530   102536       +6     
==========================================
- Hits        73228    73226       -2     
- Misses      27842    27850       +8     
  Partials     1460     1460
Flag Coverage Δ
python 79.95% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/inference/sklearn_japanese_housing_regression.py 32.83% <33.33%> (+0.02%) ⬆️
...examples/inference/sklearn_mnist_classification.py 43.13% <33.33%> (-0.62%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm damccorm marked this pull request as ready for review March 24, 2023 22:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

tvalentyn
tvalentyn reviewed Mar 24, 2023
View reviewed changes
sdks/python/apache_beam/examples/inference/sklearn_examples_requirements.txt
# limitations under the License.
#

scikit-learn==1.0.2 No newline at end of file
Copy link
Copy Markdown
Contributor

@tvalentyn tvalentyn Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will dependabot update this file?

Copy link
Copy Markdown
Contributor Author

@damccorm damccorm Mar 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure - I added a comment so that it will be obvious we should reject PRs that try to bump this.

@tvalentyn
Copy link
Copy Markdown
Contributor

tvalentyn commented Mar 24, 2023

Please fix lint & yapf and run an integration test suite that runs the example.

@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Mar 25, 2023

Please fix lint & yapf and run an integration test suite that runs the example.

Whoops, missed the linting failures - thanks.

Python3.9 postcommit does run the example, so that's already done. I'll run it again though.

@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Mar 25, 2023

Run Python 3.9 PostCommit

@damccorm damccorm merged commit cc428da into master Mar 27, 2023
@damccorm damccorm deleted the users/damccorm/sklearn_tests branch March 27, 2023 21:11
@Abacn Abacn mentioned this pull request Mar 28, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvalentyn tvalentyn tvalentyn approved these changes

Assignees

No one assigned

Labels

examples Next Action: Reviewers python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Failing Test]: Sklearn tests in apache_beam.ml.inference.sklearn_inference_it_test.SklearnInference.test_sklearn_regression is failing

2 participants

@damccorm @tvalentyn