[Python] Added Tensorflow Model Handler #25368
Merged
damccorm merged 53 commits intoapache:masterfrom Feb 15, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25368 +/- ##
==========================================
- Coverage 72.90% 72.76% -0.14%
==========================================
Files 746 749 +3
Lines 99270 99439 +169
==========================================
- Hits 72369 72357 -12
- Misses 25538 25719 +181
Partials 1363 1363
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
AnandInguva
reviewed
Feb 8, 2023
Contributor
AnandInguva
left a comment
There was a problem hiding this comment.
I did an initial review. Left few comments. Thanks!
damccorm
reviewed
Feb 8, 2023
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Thanks! This looks pretty good, just had a few questions
sdks/python/apache_beam/ml/inference/tensorflow_inference_test.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Ready for review, PTAL. Checks passed mod PyLint |
AnandInguva
approved these changes
Feb 14, 2023
Contributor
AnandInguva
left a comment
There was a problem hiding this comment.
Looks good. Just left few comments.
sdks/python/apache_beam/examples/inference/tensorflow_imagenet_segmentation.py
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/tensorflow_imagenet_segmentation.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/tensorflow_imagenet_segmentation.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/ml/inference/tensorflow_inference_it_test.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/ml/inference/tensorflow_inference_test.py
Outdated
Show resolved
Hide resolved
damccorm
reviewed
Feb 14, 2023
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Just had a few more comments, otherwise looks good (linting/formatting is also failing)
sdks/python/apache_beam/ml/inference/tensorflow_inference_it_test.py
Outdated
Show resolved
Hide resolved
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native TF Model Handler with support for
numpyandtensorflow.Tensortypes discussed in the design doc:Sample Job Run on Dataflow produces the following output for integration test: (true_label, predicted_label)
Part of #25366
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.