Fix POM of beam-sdks-java-core#24760
Merged
aromanenko-dev merged 1 commit intoapache:masterfrom Dec 22, 2022
Merged
Conversation
Member
Author
|
R: @pabloem |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Contributor
|
Run GoPortable PreCommit |
Contributor
|
Run Java_Pulsar_IO_Direct PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #24760 +/- ##
=======================================
Coverage 73.34% 73.34%
=======================================
Files 721 721
Lines 97224 97224
=======================================
+ Hits 71306 71310 +4
+ Misses 24568 24564 -4
Partials 1350 1350
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
Run Java_Pulsar_IO_Direct PreCommit |
Member
Author
|
Run Java_Kafka_IO_Direct PreCommit |
aromanenko-dev
approved these changes
Dec 22, 2022
Contributor
aromanenko-dev
left a comment
There was a problem hiding this comment.
Thanks, LGTM
Just a quick question, ptal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #24271 the pom of
beam-sdks-java-coreis broken. There's no version specified fororg.json:jsoninBeamModulePlugin:This sets the version to the transitive version resolved through
com.github.erosb:everit-json-schema:1.14.1.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.