Skip to content

Add database role to SpannerConfig for role-based access control.#23377

Merged
pabloem merged 13 commits intoapache:masterfrom
hmehrotra:master
Oct 11, 2022
Merged

Add database role to SpannerConfig for role-based access control.#23377
pabloem merged 13 commits intoapache:masterfrom
hmehrotra:master

Conversation

@hmehrotra
Copy link
Copy Markdown
Contributor

@hmehrotra hmehrotra commented Sep 27, 2022 •
edited
Loading

Please add a meaningful description for your change here
Propagate database role for fine-grained access control in Cloud Spanner.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 27, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lukecwik for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98
Copy link
Copy Markdown
Contributor

ahmedabu98 commented Sep 29, 2022

LGTM

@hmehrotra
Copy link
Copy Markdown
Contributor Author

hmehrotra commented Oct 5, 2022

R: @pabloem

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 5, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

darshan-sj
darshan-sj approved these changes Oct 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 11, 2022 •
edited
Loading

Codecov Report

Merging #23377 (b05fb88) into master (30dbe09) will increase coverage by 0.00%.
The diff coverage is 80.64%.

❗ Current head b05fb88 differs from pull request most recent head d642f04. Consider uploading reports for the commit d642f04 to get more accurate results

@@           Coverage Diff            @@
##           master   #23377    +/-   ##
========================================
  Coverage   73.45%   73.46%            
========================================
  Files         718      718            
  Lines       95770    95935   +165     
========================================
+ Hits        70352    70475   +123     
- Misses      24107    24149    +42     
  Partials     1311     1311
Flag Coverage Δ
python 83.21% <83.73%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/xlangx/expand.go 0.00% <0.00%> (ø)
sdks/python/apache_beam/ml/inference/base.py 95.65% <ø> (-0.19%) ⬇️
...thon/apache_beam/ml/inference/pytorch_inference.py 0.00% <0.00%> (ø)
...hon/apache_beam/ml/inference/tensorrt_inference.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/coders/coders.py 87.36% <65.21%> (-0.65%) ⬇️
sdks/python/apache_beam/typehints/schemas.py 91.89% <76.08%> (-1.96%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 82.91% <83.33%> (-0.09%) ⬇️
...ks/python/apache_beam/runners/worker/statecache.py 92.93% <94.66%> (+1.06%) ⬆️
sdks/python/apache_beam/coders/coder_impl.py 93.94% <100.00%> (+0.13%) ⬆️
...ks/python/apache_beam/coders/coders_test_common.py 98.58% <100.00%> (+0.03%) ⬆️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hmehrotra hmehrotra changed the base branch from master to Issue#23488 October 11, 2022 01:48
@hmehrotra hmehrotra changed the base branch from Issue#23488 to master October 11, 2022 01:48
@pabloem
Copy link
Copy Markdown
Member

pabloem commented Oct 11, 2022

lgtm. I'll merge once we get clean tests.

@pabloem pabloem merged commit c22a335 into apache:master Oct 11, 2022
@bvolpato bvolpato mentioned this pull request Nov 14, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darshan-sj darshan-sj darshan-sj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

gcp io java Next Action: Reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmehrotra @ahmedabu98 @pabloem @darshan-sj