Skip to content

Conversation

@pabloem
Copy link
Member

@pabloem pabloem commented Jan 20, 2022

…ing for JdbcIO.write* transforms""

This change had been reverted because a previous change ignored a batchSize parameter, which caused a few tests to fail. We rolled back, fixed, and rolled forward the change.

This reverts commit 421bc80.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@pabloem
Copy link
Member Author

pabloem commented Jan 20, 2022

Run Python 3.8 PostCommit

@pabloem
Copy link
Member Author

pabloem commented Jan 21, 2022

Run Python 3.8 PostCommit

@pabloem
Copy link
Member Author

pabloem commented Jan 21, 2022

Run Java PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jan 21, 2022

@pabloem
Copy link
Member Author

pabloem commented Jan 26, 2022

Run Java PostCommit

@pabloem
Copy link
Member Author

pabloem commented Jan 26, 2022

@chamikaramj PTAL

@aromanenko-dev
Copy link
Contributor

Sorry if I missed that but what is a reason to revert it?

@pabloem
Copy link
Member Author

pabloem commented Jan 26, 2022

hey @aromanenko-dev - this change had broken xlang_jdbcio_it_test. Since the release cut was coming up, and I did not mind waiting until the next release, I decided to revert it and remake the change while ensuring xlang_jdbcio_it_test would pass

@aromanenko-dev
Copy link
Contributor

Run Java PostCommit

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pabloem, thanks for details. LGTM

this change had broken xlang_jdbcio_it_test

Do you know what is a cause of this? Can it be fixed?

@chamikaramj
Copy link
Contributor

Thanks. LGTM.

Could you clarify the diff between this and the original PR in the PR description ?

@aromanenko-dev I think this includes the fix.

@pabloem
Copy link
Member Author

pabloem commented Jan 28, 2022

what happened is that the previous change ignored the batchSize parameter, and one of the python tests was verifying the batch size, which is interesting. This change now continues to respect the batchSize parameter

@pabloem
Copy link
Member Author

pabloem commented Jan 28, 2022

thanks both!

@pabloem pabloem merged commit e18e2b9 into apache:master Jan 28, 2022
@pabloem pabloem deleted the jdbcio-ash branch January 28, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants