-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Revert "Revert "Merge pull request #15863 from [BEAM-13184] Autoshard… #16579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…osharding for JdbcIO.write* transforms"" This reverts commit 421bc80.
|
Run Python 3.8 PostCommit |
|
Run Python 3.8 PostCommit |
|
Run Java PreCommit |
|
https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/393/testReport/apache_beam.io.external.xlang_jdbcio_it_test/ jdbcio xlang test works : ) @chamikaramj PTAL |
|
Run Java PostCommit |
|
@chamikaramj PTAL |
|
Sorry if I missed that but what is a reason to revert it? |
|
hey @aromanenko-dev - this change had broken |
|
Run Java PostCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pabloem, thanks for details. LGTM
this change had broken xlang_jdbcio_it_test
Do you know what is a cause of this? Can it be fixed?
|
Thanks. LGTM. Could you clarify the diff between this and the original PR in the PR description ? @aromanenko-dev I think this includes the fix. |
|
what happened is that the previous change ignored the batchSize parameter, and one of the python tests was verifying the batch size, which is interesting. This change now continues to respect the batchSize parameter |
|
thanks both! |
…ing for JdbcIO.write* transforms""
This change had been reverted because a previous change ignored a batchSize parameter, which caused a few tests to fail. We rolled back, fixed, and rolled forward the change.
This reverts commit 421bc80.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.