[BEAM-13521] portable spark precommit#16345
Conversation
|
run seed job |
|
run Java_PVR_Spark_Batch precommit |
|
run seed job |
|
run Java_PVR_Spark_Batch precommit |
|
Looks like the job is stuck again, but that's not new. |
udim
left a comment
There was a problem hiding this comment.
AFAICT, errors are consistent with the ones encountered in the recent migration to Gradle 7: https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch_PR/197/
|
How much would this be adding to the current wait time for precommits (assuming this runs in parallel)? The last run was 90m (but with errors). |
|
Was this helpful after all? Should it be merged? |
|
Should we close this? |
|
I think Udi is right to be concerned with the amount of latency this would introduce, if it's not cached this job routinely takes between 90 and 120 minutes. https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/buildTimeTrend So I'll close it for now. |
|
As an intermediate step, we don't need to run all the tests as a precommit - just running a subset of the tests would presumably be faster and would already provide useful signal in many cases. |
|
Thank you both. I agree with the decision and the intermediate step. Let's make sure that the JIRA is updated and we can work on it at a later time. Thank you very much for carrying this until this point. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.