Skip to content

[BEAM-13480] Sickbay PubSubIntegrationTest.test_streaming_data_only on Dataflow #16255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheNeuralBit merged 1 commit into from
Jan 4, 2022
Merged

[BEAM-13480] Sickbay PubSubIntegrationTest.test_streaming_data_only on Dataflow #16255

TheNeuralBit merged 1 commit into from
Jan 4, 2022

Conversation

@yeandy
Copy link
Contributor

@yeandy yeandy commented Dec 16, 2021 •
edited by TheNeuralBit
Loading

In addition to the failures of PubSubIntegrationTest.test_streaming_with_attributes, its counterpart PubSubIntegrationTest.test_streaming_data_only (previously sickbayed) is now flaking. I will sickbay the test_streaming_data_only test as well.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status 		Build Status
Build Status 		Build Status
Build Status
Build Status 		Build Status
Python --- Build Status
Build Status
Build Status 		Build Status
Build Status 		Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status 		Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@yeandy
Copy link
Contributor Author

yeandy commented Dec 16, 2021

Run Python 3.6 PostCommit

@codecov
Copy link

codecov bot commented Dec 16, 2021 •
edited
Loading

Codecov Report

Merging #16255 (ebfd080) into master (4835700) will increase coverage by 37.50%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #16255       +/-   ##
===========================================
+ Coverage   46.13%   83.64%   +37.50%     
===========================================
  Files         197      447      +250     
  Lines       19519    61692    +42173     
===========================================
+ Hits         9006    51605    +42599     
- Misses       9542    10087      +545     
+ Partials      971        0      -971
Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/exec/reshuffle.go
sdks/go/pkg/beam/core/runtime/harness/session.go
sdks/go/pkg/beam/util/starcgenx/starcgenx.go
sdks/go/pkg/beam/core/graph/coder/row_encoder.go
sdks/go/pkg/beam/core/runtime/exec/pcollection.go
sdks/go/pkg/beam/artifact/stage.go
sdks/go/pkg/beam/core/runtime/metricsx/urns.go
sdks/go/pkg/beam/core/util/hooks/hooks.go
sdks/go/pkg/beam/core/metrics/metrics.go
sdks/go/pkg/beam/core/runtime/exec/util.go
... and 634 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4835700...ebfd080. Read the comment docs.

@aaltay aaltay requested a review from TheNeuralBit December 29, 2021 18:25
@TheNeuralBit TheNeuralBit changed the title [BEAM-13480] Sickbay PubSubIntegrationTest.streaming_data_only [BEAM-13480] Sickbay PubSubIntegrationTest.test_streaming_data_only on Dataflow Jan 4, 2022
TheNeuralBit
TheNeuralBit approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like the test is just very flaky, not a hard failure. I updated the PR description to that effect.

By sickbaying this I don't think we have any verification of the Dataflow pubsub source/sink from Python, so we should definitely prioritize debugging the issue to get that signal back.

@TheNeuralBit TheNeuralBit merged commit 36ce02b into apache:master Jan 4, 2022
@yeandy
Copy link
Contributor Author

yeandy commented Jan 5, 2022

Sounds good.

@yeandy yeandy mentioned this pull request Jan 12, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheNeuralBit TheNeuralBit TheNeuralBit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yeandy @TheNeuralBit