Skip to content

Commit dbaa8dc

Browse files
AbacnBruno Volpato
authored andcommitted
Fix jdbc xlang schema type mismatch (#26480)
* Fix jdbc xlang schema type mismatch * Also fix fetch_size type mismatch * Add new fields in the end
1 parent 0762aad commit dbaa8dc

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,12 @@ public Schema configurationSchema() {
6767
.addNullableField("fetchSize", FieldType.INT16)
6868
.addNullableField("outputParallelization", FieldType.BOOLEAN)
6969
.addNullableField("autosharding", FieldType.BOOLEAN)
70-
.addNullableField("maxConnections", FieldType.INT16)
71-
.addNullableField("driverJars", FieldType.STRING)
7270
// Partitioning support. If you specify a partition column we will use that instead of
7371
// readQuery
7472
.addNullableField("partitionColumn", FieldType.STRING)
7573
.addNullableField("partitions", FieldType.INT16)
74+
.addNullableField("maxConnections", FieldType.INT16)
75+
.addNullableField("driverJars", FieldType.STRING)
7676
.build();
7777
}
7878

sdks/python/apache_beam/io/jdbc.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,12 @@ def default_io_expansion_service(classpath=None):
120120
('connection_init_sqls', typing.Optional[typing.List[str]]),
121121
('read_query', typing.Optional[str]),
122122
('write_statement', typing.Optional[str]),
123-
('fetch_size', typing.Optional[int]),
123+
('fetch_size', typing.Optional[np.int16]),
124124
('output_parallelization', typing.Optional[bool]),
125125
('autosharding', typing.Optional[bool]),
126126
('partition_column', typing.Optional[str]),
127127
('partitions', typing.Optional[np.int16]),
128-
('max_connections', typing.Optional[int]),
128+
('max_connections', typing.Optional[np.int16]),
129129
('driver_jars', typing.Optional[str])],
130130
)
131131

0 commit comments

Comments
 (0)