Merge pull request #24236: Remove overly broad CanIgnoreReturnValue

kennknowles · web-flow · commit 0310365db5ef · 2022-11-18T15:54:30.000-08:00
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOptions.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOptions.java
@@ -34,10 +34,10 @@ public static Builder newBuilder() {
     return new AutoValue_PublisherOptions.Builder();
   }
 
-  @CanIgnoreReturnValue
   @AutoValue.Builder
   public abstract static class Builder {
     // Required parameters.
+    @CanIgnoreReturnValue
     public abstract Builder setTopicPath(TopicPath path);
 
     public abstract PublisherOptions build();
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscriberOptions.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscriberOptions.java
@@ -35,10 +35,10 @@ public static Builder newBuilder() {
 
   public abstract Builder toBuilder();
 
-  @CanIgnoreReturnValue
   @AutoValue.Builder
   public abstract static class Builder {
     // Required parameters.
+    @CanIgnoreReturnValue
     public abstract Builder setSubscriptionPath(SubscriptionPath path);
 
     public abstract SubscriberOptions build();
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/UuidDeduplicationOptions.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/UuidDeduplicationOptions.java
@@ -69,7 +69,6 @@ public static Builder newBuilder() {
     return builder;
   }
 
-  @CanIgnoreReturnValue
   @AutoValue.Builder
   public abstract static class Builder {
     public abstract Builder setUuidExtractor(
@@ -84,6 +83,7 @@ public abstract Builder setUuidExtractor(
      *     .withTimeDomain(TimeDomain.PROCESSING_TIME));
      * }</pre>
      */
+    @CanIgnoreReturnValue
     public abstract Builder setDeduplicate(
         Deduplicate.KeyedValues<Uuid, SequencedMessage> deduplicate);
 
