Add csv with nulls. #103
Closed
Add csv with nulls. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Needed for unit tests added in apache/datafusion#13228 |
Author
|
Updating associated pr to keep test data within the datafusion repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding data to support testing for Nulls here:
apache/datafusion#12904
I looked at making this change directly in
aggregate_test_100.csv(adding the two null columns) but there are 75 tests tightly coupled to the format of the csv.If the data duplication is a concern, I think it would still be better to duplicate temporarily and incrementally updates tests to use the new
aggregate_test_100_with_nulls. Then when the test logic is fixed reduce to a single testing csv.