Skip to content

Bump rand to 0.9#303

Merged
alamb merged 2 commits into
apache:mainfrom
mbrobbel:rand
Mar 24, 2025
Merged

Bump rand to 0.9#303
alamb merged 2 commits into
apache:mainfrom
mbrobbel:rand

Conversation

@mbrobbel

Copy link
Copy Markdown
Member

Which issue does this PR close?

Rationale for this change

https://rust-random.github.io/book/update-0.9.html

What changes are included in this PR?

The required changes to migrate from 0.8 to 0.9.

Are there any user-facing changes?

rand dependency bumped to 0.9.

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mbrobbel 🙏

Comment thread src/client/backoff.rs
/// Creates a new `Backoff` with the optional `rng`
///
/// Used [`rand::thread_rng()`] if no rng provided
/// Used [`rand::rng()`] if no rng provided

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sadly this change means it is a breaking API change, right?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is pub(crate), so it's not a breaking change.

@alamb alamb added the next-major-release the PR has API changes and it waiting on the next major version label Mar 24, 2025
@alamb

alamb commented Mar 24, 2025

Copy link
Copy Markdown
Contributor

I also filed a ticket to discuss the next release

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbrobbel

@alamb alamb removed the next-major-release the PR has API changes and it waiting on the next major version label Mar 24, 2025
@alamb alamb merged commit 308dba4 into apache:main Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants