Skip to content

object_store: Incorrect parsing of https Path Style S3 url #175

@trueleo

Description

@trueleo

Description
Currently, the S3 bucket URL parsing for AWS here is mistakenly parsing the bucket out of URL https://s3.bucket.amazonaws.com. However, this URL does not represent a valid S3 bucket URL format. The correct format should be https://s3.region.amazonaws.com/bucket for Path style as mentioned in AWS user guide here

Expected behavior
The parse_url method on builder should correctly parse the S3 bucket URL and set region and bucket accordingly.

Additional context
Invalid URL in Test
parse_url

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions