arrow-cast: Add display formatter for ListView #9175
Merged
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Clippy failures seem unrelated; that code wasn't touched in this patch. |
Contributor
I think it would be good to add a test case somewhere, even if we didn't have any for the others. |
Jefffrey
approved these changes
Jan 15, 2026
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9173
Are these changes tested?
I didn't add unit tests since the other formatters don't appear to be unit tested either, is the idea to test these via sql logic tests in df?
Are there any user-facing changes?
No, just additive functionality
@alamb @Jefffrey