arrow-buffer: implement num-traits numeric operations #8977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Dec 11, 2025
| Some(i256::from_i128(5)) | ||
| ); | ||
|
|
||
| assert_eq!( |
Contributor
There was a problem hiding this comment.
Thank you for these tests -- can we also test the others (checked_sub, for example)?
Contributor
Author
There was a problem hiding this comment.
Yes, sure, let me add them for completeness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
i256doesn't implement some numeric traits. It'd be good to have it supported alongside other standard types.What changes are included in this PR?
Num,One,Zero) using already written methodsNot all traits are implemented (checked shl/shr, pow is not here yet). The main point of this PR is to provide a starting implementation.
Are these changes tested?
Tested via new unit test
Are there any user-facing changes?
Only new trait implementation.