arrow-buffer: make i256::leading_zeros public and tested #8964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make `i256::leading_zeros` public to align with other integer types - Add function documentation - Add unit tests
1fbb635 to
8307c5c
Compare
Contributor
|
I merged up to resolve some merge conflicts |
Contributor
|
Thanks again @theirix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
leading_zerosexists for other integer types, and in widei128as well. This PR makes it public and tested. It's worth having it as a public part of the struct.What changes are included in this PR?
Are these changes tested?
Yes, via unit tests.
Are there any user-facing changes?
No