Allow creating zero-sized FixedSizeBinary arrays #8927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
approved these changes
Nov 26, 2025
| let zero_sized_with_non_empty_buffer = FixedSizeBinaryArray::try_new(0, buffer, None); | ||
| assert!( | ||
| matches!( | ||
| zero_sized_with_non_empty_buffer, |
Contributor
There was a problem hiding this comment.
Perhaps assert the contents of the string as is done above (err.to_string())
Contributor
|
Thanks @tobixdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FixedSizeBinaryArray::try_new(...)Panics with Item Length of Zero #8926 .Note that creating sch arrays was already possible with the builder API (see
test_fixed_size_binary_builder_with_zero_value_length) but not directly with the Array API.Rationale for this change
Avoid panicking (divide by zero) in
FixedSizeBinaryArray::try_new(0, ...)What changes are included in this PR?
Special case for
size == 0inFixedSizeBinaryArray::try_new.Are these changes tested?
Yes, additional constructor tests.
Are there any user-facing changes?
Yes, no panics and the ability to directly create FSB arrays with zero-length items.